introduce SMV enumeration type #1154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
smv-enumeration-type
branch
4 times, most recently
from
f3f9ae8 to
2fc9d2b
Compare
kroening
force-pushed
the
smv-enumeration-type
branch
from
2fc9d2b to
b2da631
Compare
kroening
force-pushed
the
smv-enumeration-type
branch
2 times, most recently
from
28a3c20 to
554935c
Compare
tautschnig
reviewed
Jul 23, 2025
src/smvlang/smv_types.cpp
Outdated
| for(auto &element1 : elements()) | ||
| { | ||
| bool found = false; | ||
| for(auto &element2 : other.elements()) |
There was a problem hiding this comment.
Given the realistic size of enums the quadratic algorithm might not matter too much, but repeatedly invoking other.elements() seems avoidable. This should be other.find(ID_elements).get_sub() instead.
There was a problem hiding this comment.
Now replaced by a set, which makes this n log n.
kroening
force-pushed
the
smv-enumeration-type
branch
from
554935c to
2fb77f9
Compare
tautschnig
approved these changes
Jul 25, 2025
src/smvlang/smv_types.cpp
Outdated
| for(auto &element : other_elements_sub) | ||
| other_elements.insert(element.id()); | ||
|
|
||
| for(auto &element : elements()) |
There was a problem hiding this comment.
Thank you for removing the quadratic approach. But I don't think we should use elements() here either as for(auto &e : find(ID_elements).get_sub()) would avoid constructing the vector.
kroening
force-pushed
the
smv-enumeration-type
branch
3 times, most recently
from
3ba9b05 to
203f9d0
Compare
SMV enumerations behave differently from enumeration_typet; hence, this introduces smv_enumeration_typet, which is subsequently lowered to enumeration_typet.
kroening
force-pushed
the
smv-enumeration-type
branch
from
203f9d0 to
caeaab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SMV enumerations behave differently from
enumeration_typet; hence, this introducessmv_enumeration_typet, which is subsequently lowered toenumeration_typet.